Initialise large enough, same-const-initialised, arrays using loops #5240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGI-111
approved these changes
Oct 30, 2023
tritao
approved these changes
Oct 30, 2023
|
Maybe I am misunderstanding, but the test doesn't actually check that the optimization is working right? We would need an IR test for that? |
You're right, it just checks that, if the optimisation happens, it doesn't end up being incorrect.
Ideally yes. The problem is that this isn't really an optimisation pass. It's just a different IR gen, so I can't test it using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5229
Previously, these arrays were initialised with repeated "load index from data area, store initialise constant to array". Now we just use a loop to store the constant initialise to every element of the array. To avoid overheads of the loop, it's only done, currently, when the array size is greater than 5 (can be tuned later).