Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom LSP method for visualizing build plan #5243

Merged
merged 8 commits into from
Nov 1, 2023
Merged

Add custom LSP method for visualizing build plan #5243

merged 8 commits into from
Nov 1, 2023

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Oct 30, 2023 •
edited
Loading

Description

Related FuelLabs/sway-vscode-plugin#105

Here is the front end change: FuelLabs/sway-vscode-plugin#162

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel changed the title Sophie/graphviz Add custom LSP method for visualizing build plan Oct 30, 2023
@sdankel sdankel marked this pull request as ready for review October 30, 2023 23:00
@sdankel sdankel requested a review from kayagokalp as a code owner October 30, 2023 23:00
@sdankel sdankel requested a review from a team October 30, 2023 23:00
@JoshuaBatty JoshuaBatty added the language server LSP server label Oct 30, 2023
JoshuaBatty
JoshuaBatty approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good.

@JoshuaBatty JoshuaBatty requested a review from a team October 30, 2023 23:58
kayagokalp
kayagokalp approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@sdankel sdankel merged commit f390041 into master Nov 1, 2023
31 checks passed
@sdankel sdankel deleted the sophie/graphviz branch November 1, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayagokalp kayagokalp kayagokalp approved these changes

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

Assignees

@sdankel sdankel

Labels
language server LSP server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdankel @JoshuaBatty @kayagokalp