Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow implicit stdlib to be configured with env vars #5249

Merged
merged 3 commits into from
Nov 2, 2023
Merged

allow implicit stdlib to be configured with env vars #5249

merged 3 commits into from
Nov 2, 2023

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Nov 1, 2023 •
edited
Loading

Description

This PR is needed to make FuelLabs/fuels-rs#1163 green. We can configure the sway branch for the CI, but not the stdlib. With this, we will be able to edit github CI config and point to whichever sway version we want.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj force-pushed the xunilrj/implicit-std-env-vars branch from ce3b341 to 089097e Compare November 1, 2023 19:10
@xunilrj xunilrj marked this pull request as ready for review November 2, 2023 22:44
@xunilrj xunilrj requested a review from kayagokalp as a code owner November 2, 2023 22:44
@IGI-111 IGI-111 enabled auto-merge (squash) November 2, 2023 23:20
@IGI-111 IGI-111 merged commit f29ce32 into master Nov 2, 2023
26 checks passed
@IGI-111 IGI-111 deleted the xunilrj/implicit-std-env-vars branch November 2, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@tritao tritao tritao approved these changes

@kayagokalp kayagokalp Awaiting requested review from kayagokalp

Assignees

@xunilrj xunilrj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xunilrj @tritao @IGI-111