-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to v0.48.0 #5275
Bump to v0.48.0 #5275
Conversation
f11df58
to
742a6ab
Compare
@ironcev Can you look at that failing test? |
I think it was locked to v0.47 of the std lib. I've just updated it to
|
I feel like this might not work because forc will realize lock file is not valid and it will try to fetch. std v0.48 is not released yet but forc will try to get that one. We should always point to std by path in test suite to prevent issues popping out while releasing.
Note: I am writing this without having access to the file structure at the moment so amount of |
Ok good idea @kayagokalp i'll update it now. We should probably make sure this pattern is done is all tests in a follow up PR |
d6c8c15 was missing the lock file for the test with std pointing to local. That would also cause test suite to fail as forc will throw warnings. I added the lock file back with std pointed to local version. (simply executed forc build after d6c8c15) in 2875be8. Sorry for pushing to your branch unannounced 😅 |
Thanks, @kayagokalp :) |
## Description This PR extends tests with the checks that prove that the E2e and the SDK harness tests are consistent. In the first step, we are checking the test Forc.toml files for the following aspects: - proper `authors` - proper `license` - proper `implicit-std` - proper import of standard libraries The last two points are of particular importance, because they can cause tests fail when, e.g., bumping to new versions. These checks will eliminate the issues like we had [when merging Bump to v0.48.0](#5275 (comment)). The PR also fixes issues found in existing tests, most notably: - unrelated test project names that stayed after copy-pasting tests - `authors` different than _Fuel Labs_ - inconsistent lib import paths ## Demo ![Various errors](https://github.com/FuelLabs/sway/assets/4142833/ef707a37-e672-40d4-8af7-4848e69fa582) ![Std library is not properly imported](https://github.com/FuelLabs/sway/assets/4142833/0a9de98b-fc5a-455a-9877-28b4111f4c67) ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
waiting on
fixtures-std
andfixtures-core
dirs and usestd v0.47.0
for lsp tests #5274