-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide useful error for "Cannot find trait Hash in this scope" #5293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ironcev
added
compiler
General compiler. Should eventually become more specific as the issue is triaged
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
labels
Nov 20, 2023
sdankel
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
tritao
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
compiler
General compiler. Should eventually become more specific as the issue is triaged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #5129 by providing a detailed guidelines to programmers on how to fix the "Cannot find trait XYZ in this scope". The issue is very prominent in the case of the
Hash
trait as demonstrated in the #5084.We need to guide programmers at the moment because fixing the root cause will take some time. (Changes need to fix the root cause are sketched in this comment).
The PR:
Hash
trait.SymbolNotFound
duplicated error and leaves only the specificTraitNotFound
Closes #5129.
Demo
These were the original redundant and misleading error messages produced at the function definition side:
This is the new error message:
In the case of an ambiguous trait, a detailed instructions are provided on how to find and import the required trait:
Checklist
Breaking*
orNew Feature
labels where relevant.