Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Forc.lock files in LSP tests #5294

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Remove Forc.lock files in LSP tests #5294

merged 1 commit into from
Nov 21, 2023

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Nov 21, 2023

Description

These don't need to be included and they were causing issues with out of date packages being pinned.

@JoshuaBatty JoshuaBatty self-assigned this Nov 21, 2023
@JoshuaBatty JoshuaBatty added language server LSP server testing General testing labels Nov 21, 2023
@JoshuaBatty JoshuaBatty requested review from a team November 21, 2023 09:35
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) November 21, 2023 09:35
@JoshuaBatty JoshuaBatty requested a review from a team November 21, 2023 09:36
@JoshuaBatty JoshuaBatty merged commit a41f617 into master Nov 21, 2023
32 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/forc_locks branch November 21, 2023 10:02
@sdankel sdankel mentioned this pull request Dec 13, 2023
7 tasks
sdankel added a commit that referenced this pull request Dec 14, 2023
## Description

Prevent people from accidentally checking in the Forc.lock files in sway
LSP tests.

Follow up to #5294

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language server LSP server testing General testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants