Changes ConcurrentSlab to no longer clone values
#5313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
force-pushed
the
concurrent_slab_without_clone
branch
5 times, most recently
from
ba79778 to
91e5855
Compare
ironcev
reviewed
Dec 1, 2023
`ConcurrentSlab` now stores and returns an Arc, and on `get` it only clones an Arc which is much cheaper than cloning the whole values. The type engine is still cloning every TypeInfo we should be able to also avoid that and get further improvments in speed. With these changes core + std-lib compilation improved from around 3 secs to 1.5 secs.
esdrubal
force-pushed
the
concurrent_slab_without_clone
branch
3 times, most recently
from
6a9fe44 to
6be89ed
Compare
esdrubal
force-pushed
the
concurrent_slab_without_clone
branch
from
6be89ed to
55f439d
Compare
ironcev
approved these changes
Dec 2, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ConcurrentSlabnow stores and returns an Arc, and ongetit only clones an Arc which is much cheaper than cloning the whole values.The type engine is still cloning every TypeInfo we should be able to also avoid that and get further improvements in speed.
With these changes core + std-lib compilation improved from around 3 secs to 1.5 secs.
cargo run --bin test --releaseis running in around 8min versus 16min in master.Checklist
Breaking*orNew Featurelabels where relevant.