You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically some contracts don't necessarily must have contract methods.
In theory I think we should always be able to get a valid module id, so even if they have no contracts, we should be able to get a module id. Is there maybe a span on the contract itself we could use?
In theory I think we should always be able to get a valid module id, so even if they have no contracts, we should be able to get a module id. Is there maybe a span on the contract itself we could use?
I changed it to use the module_id from the Module being type_checked.
But I still think we must not expect a module_id to exist in all cases, given that the data model supports None.
In theory I think we should always be able to get a valid module id, so even if they have no contracts, we should be able to get a module id. Is there maybe a span on the contract itself we could use?
I changed it to use the module_id from the Module being type_checked. But I still think we must not expect a module_id to exist in all cases, given that the data model supports None.
New approach looks good. Not sure about None, in my undersanding we should always be compiling some kind of forc pkg, which should always have a valid module id, but without checking further I can't really say.
I think its good enough to merge like like though.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
source_id
optional when auto generation code. Specifically some contracts don't necessarily must have contract methods.Checklist
Breaking*
orNew Feature
labels where relevant.