Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup duplicated data from ty::TyDecl #5751

Merged
merged 21 commits into from
May 6, 2024
Merged

Cleanup duplicated data from ty::TyDecl #5751

merged 21 commits into from
May 6, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Mar 19, 2024 •
edited
Loading

Description

This PR cleans up the ty::TyDecl struct by removing fields for duplicated data that we already have access through the engines. Have not measured the true impact of this, but should have a noticeable performance and especially memory improvement.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao force-pushed the cleanup-ty-decl branch 4 times, most recently from ad6c840 to 87ddf58 Compare March 19, 2024 16:39
@tritao tritao force-pushed the cleanup-ty-decl branch 8 times, most recently from 6759b60 to 2499182 Compare May 3, 2024 15:32
@tritao tritao self-assigned this May 3, 2024
@tritao tritao added code quality performance Everything related to performance, speed wise or memory wise. labels May 3, 2024
@tritao tritao changed the title Cleanup TyDecl Cleanup duplicated data from ty::TyDecl May 3, 2024
@tritao tritao force-pushed the cleanup-ty-decl branch from 2499182 to c50f765 Compare May 3, 2024 15:58
@tritao tritao marked this pull request as ready for review May 3, 2024 15:58
@tritao tritao requested review from a team May 3, 2024 15:58
JoshuaBatty
JoshuaBatty previously approved these changes May 4, 2024
View reviewed changes
@JoshuaBatty JoshuaBatty requested review from a team May 4, 2024 10:13
IGI-111
IGI-111 previously approved these changes May 6, 2024
View reviewed changes
@IGI-111 IGI-111 dismissed stale reviews from JoshuaBatty and themself via fceb88e May 6, 2024 02:17
@IGI-111 IGI-111 requested review from JoshuaBatty and a team May 6, 2024 02:19
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) May 6, 2024 02:54
@JoshuaBatty JoshuaBatty merged commit 1fd9e47 into FuelLabs:master May 6, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

Assignees

@tritao tritao

Labels
code quality performance Everything related to performance, speed wise or memory wise.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tritao @JoshuaBatty @IGI-111