-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add log decoding capabilities to show decoded log values for forc-test #5812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
added
enhancement
New feature or request
forc
forc-test
Everything related to the `forc-test` lib and `forc test` command.
labels
Apr 1, 2024
kayagokalp
force-pushed
the
kayagokalp/log-decode
branch
from
April 29, 2024 21:31
f03a1e7
to
09a6630
Compare
kayagokalp
force-pushed
the
kayagokalp/log-decode
branch
from
April 30, 2024 00:00
58a3696
to
6cb8a9b
Compare
sdankel
reviewed
May 14, 2024
sdankel
approved these changes
May 15, 2024
JoshuaBatty
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
forc
forc-test
Everything related to the `forc-test` lib and `forc test` command.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds log decoding capabilities to forc, so that it can be used for showing actual decoded, human readable values at forc-test output.
For the following unit test:
Logs are:
Also this PR fixes a bug in test suite which causes test suite to omit the encoding information passed into forc-test from
unit_tests_pass
tests. And adds log decode testing capabilities to the test suite.Next up is adding actual variable names instead of log id so that decoded log values will show as, this is left to a future PR
Decoded log: ( a = 10 )
Decoded log: ( b = 30 )