-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve errors when the entry fns cannot be generated #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for d8c8acdClick to view benchmark
|
Benchmark for af8c0f4Click to view benchmark
|
Benchmark for 7f9340cClick to view benchmark
|
Benchmark for c663ef2Click to view benchmark
|
xunilrj
added
the
breaking
May cause existing user code to break. Requires a minor or major release.
label
Apr 4, 2024
Benchmark for 6764d51Click to view benchmark
|
IGI-111
reviewed
Apr 4, 2024
Benchmark for 4ce2783Click to view benchmark
|
IGI-111
approved these changes
Apr 8, 2024
Merged
tritao
approved these changes
Apr 9, 2024
xunilrj
force-pushed
the
xunilrj/improve-err-msg-new-encoding
branch
from
April 9, 2024 12:46
3ca56c1
to
1f498b8
Compare
Benchmark for 5570e1dClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves fix a problem when a type cannot be auto-impled and improve error messages for this case.
This can be seen on
tests/types/contracts/type_inside_enum
in the Rust SDK repo.Given that this PR also improve implementation of arrays for
AbiEncode
andAbiDecode
, the entry function is actually generated. But in case of error, it will fail like:Checklist
Breaking*
orNew Feature
labels where relevant.