Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow conversions between native u types and U128 #5825

Merged
merged 14 commits into from
Apr 24, 2024
Merged

Allow conversions between native u types and U128 #5825

merged 14 commits into from
Apr 24, 2024

Conversation

SwayStar123
Copy link
Member

Description

Adds impl From<u8,u16,u32,u64> for U128

Partially addresses #5797

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 added enhancement New feature or request lib: std Standard library labels Apr 3, 2024
@SwayStar123 SwayStar123 requested review from bitzoic and K1-R1 April 3, 2024 09:51
@SwayStar123 SwayStar123 self-assigned this Apr 3, 2024
@SwayStar123 SwayStar123 marked this pull request as draft April 3, 2024 12:07
@SwayStar123
Copy link
Member Author

Blocked by #5826

@SwayStar123 SwayStar123 marked this pull request as ready for review April 15, 2024 13:35
bitzoic
bitzoic requested changes Apr 16, 2024
View reviewed changes
sway-lib-std/src/u128.sw Show resolved Hide resolved
sway-lib-std/src/u128.sw Outdated Show resolved Hide resolved
@SwayStar123 SwayStar123 requested a review from bitzoic April 18, 2024 13:15
K1-R1
K1-R1 requested changes Apr 18, 2024
View reviewed changes
sway-lib-std/src/u128.sw Outdated Show resolved Hide resolved
sway-lib-std/src/u128.sw Outdated Show resolved Hide resolved
sway-lib-std/src/u128.sw Outdated Show resolved Hide resolved
SwayStar123 and others added 3 commits April 19, 2024 10:17
@SwayStar123 @K1-R1
Update sway-lib-std/src/u128.sw
ffdae6e 
Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
@SwayStar123 @K1-R1
Update sway-lib-std/src/u128.sw
c227bef 
Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
@SwayStar123 @K1-R1
Update sway-lib-std/src/u128.sw
8eeb776 
Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
@SwayStar123 SwayStar123 requested a review from K1-R1 April 19, 2024 04:47
@SwayStar123 SwayStar123 enabled auto-merge (squash) April 24, 2024 06:44
@SwayStar123 SwayStar123 merged commit 7d28830 into master Apr 24, 2024
33 checks passed
@SwayStar123 SwayStar123 deleted the to-u128-implementations branch April 24, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1-R1 K1-R1 K1-R1 approved these changes

@bitzoic bitzoic bitzoic approved these changes

Assignees

@SwayStar123 SwayStar123

Labels
enhancement New feature or request lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwayStar123 @bitzoic @K1-R1