Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail nicer on missing expected_result in test.toml files #5941

Merged
merged 1 commit into from
May 1, 2024

Conversation

jjcnn
Copy link
Contributor

@jjcnn jjcnn commented May 1, 2024

Description

If the test.toml file in a test does not contain the entries expected_result and expected_result_new_encoding, the end-to-end tests fail with an unhelpful error message.

This PR improves the error message.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@jjcnn jjcnn requested a review from a team May 1, 2024 16:16
@xunilrj xunilrj merged commit 2c20592 into master May 1, 2024
36 checks passed
@xunilrj xunilrj deleted the jjcnn/fail-nicer-on-missing-new-encoding-in-tests branch May 1, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants