Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Split contract-specific namespace module code into its own file. #5948

Merged
merged 1 commit into from
May 6, 2024
Merged

Refactor: Split contract-specific namespace module code into its own file. #5948

merged 1 commit into from
May 6, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented May 2, 2024 •
edited
Loading

Description

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added the compiler General compiler. Should eventually become more specific as the issue is triaged label May 2, 2024
@tritao tritao self-assigned this May 2, 2024
@tritao tritao force-pushed the module-remove-contract branch 2 times, most recently from dbe476a to e8f0836 Compare May 2, 2024 15:20
@tritao tritao marked this pull request as ready for review May 2, 2024 17:13
@tritao tritao requested a review from kayagokalp as a code owner May 2, 2024 17:13
@tritao tritao requested review from a team and jjcnn May 2, 2024 17:13
JoshuaBatty
JoshuaBatty previously approved these changes May 3, 2024
View reviewed changes
@JoshuaBatty JoshuaBatty requested review from a team May 3, 2024 00:34
IGI-111
IGI-111 previously approved these changes May 6, 2024
View reviewed changes
jjcnn
jjcnn previously approved these changes May 6, 2024
View reviewed changes
@tritao tritao requested review from JoshuaBatty, IGI-111 and jjcnn May 6, 2024 11:04
@tritao tritao dismissed stale reviews from jjcnn, IGI-111, and JoshuaBatty via ed4f991 May 6, 2024 11:04
@tritao tritao force-pushed the module-remove-contract branch from cc9fc7d to ed4f991 Compare May 6, 2024 11:04
@tritao
Copy link
Contributor Author

tritao commented May 6, 2024 •
edited
Loading

Rebased.

@tritao tritao enabled auto-merge (squash) May 6, 2024 11:05
@JoshuaBatty JoshuaBatty requested review from a team May 6, 2024 11:52
@tritao tritao merged commit 7c926d2 into FuelLabs:master May 6, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@kayagokalp kayagokalp Awaiting requested review from kayagokalp

@jjcnn jjcnn Awaiting requested review from jjcnn

Assignees

@tritao tritao

Labels
compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tritao @JoshuaBatty @IGI-111 @jjcnn