-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Self::zero
and self::is_zero()
for 13 types
#5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know Rust's As in Rust, incidentally. |
K1-R1
previously approved these changes
May 13, 2024
Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
K1-R1
previously approved these changes
May 14, 2024
bitzoic
changed the title
Introduce the
Introduce May 22, 2024
Zero
traitSelf::zero
and self::is_zero()
for 13 types
xunilrj
previously approved these changes
May 22, 2024
IGI-111
previously approved these changes
May 22, 2024
IGI-111
approved these changes
May 22, 2024
tritao
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the following functions to be implemented:
zero()
is_zero()
This falls inline with what we see in Rust's Zero Trait, making the language feel and look more like Rust.
This PR also deprecates the following:
ZERO_B256
->b256::zero()
ZERO_U256
->u256::zero()
To define a
u256
orb256
zero address, the following should be used:A common use of the
ZERO_B256
was to define the zero addresses and contract id`:The following is now possible:
The following types now implement the
Zero
trait:u8
u16
u32
u64
u256
b256
SubId
AssetId
ContractId
Address
EvmAddress
U128
B512
Closes #5830
Checklist
Breaking*
orNew Feature
labels where relevant.