Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable name-resolution-after-monomorphization again #5996

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented May 13, 2024

Description

This test was disabled when enabling encoding V1 because I had to include core on this project. That made the method neq ambiguous. And the compiler was correctly pointing this out.

There is no bug here, the only solution is to rename this method (what I did). I also left the trait with the same name to make the resolution more complex.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj requested a review from a team May 13, 2024 10:41
@xunilrj xunilrj self-assigned this May 13, 2024
@xunilrj xunilrj mentioned this pull request May 13, 2024
28 tasks
@xunilrj xunilrj requested a review from a team May 13, 2024 11:28
@IGI-111 IGI-111 enabled auto-merge (squash) May 13, 2024 15:11
@IGI-111 IGI-111 merged commit 675135f into master May 13, 2024
33 of 34 checks passed
@IGI-111 IGI-111 deleted the xunilrj/encoding-stabilization-test-name-resolution-after-monomorphization branch May 13, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants