Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in fndedup for fuelvm instructions #6045

Merged
merged 5 commits into from
May 22, 2024

Conversation

vaivaswatha
Copy link
Contributor

@vaivaswatha vaivaswatha commented May 22, 2024

Description

We weren't differentiating the various fuelvm instructions. So this fix adds a line to differentiate based on the discriminator of the fuelvm instruction.

Similarly, we weren't differentiating constants and configurables. That has a similar fix too.

@vaivaswatha vaivaswatha requested a review from a team May 22, 2024 07:34
@vaivaswatha vaivaswatha self-assigned this May 22, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
IGI-111
IGI-111 previously approved these changes May 22, 2024
@IGI-111 IGI-111 requested a review from a team May 22, 2024 08:16
tritao
tritao previously approved these changes May 22, 2024
@vaivaswatha vaivaswatha dismissed stale reviews from tritao and IGI-111 via 6fe4373 May 22, 2024 08:29

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@tritao tritao requested a review from IGI-111 May 22, 2024 08:29
@vaivaswatha vaivaswatha enabled auto-merge (squash) May 22, 2024 08:38
@vaivaswatha vaivaswatha merged commit 9af5d12 into master May 22, 2024
37 checks passed
@vaivaswatha vaivaswatha deleted the vaivaswatha/fndedup_fuelvm_fix branch May 22, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants