-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify namespace import logic for parsed and typed declarations #6057
Merged
tritao
merged 10 commits into
FuelLabs:master
from
tritao:unify-namespaces-parsed-typed
Jun 17, 2024
Merged
Unify namespace import logic for parsed and typed declarations #6057
tritao
merged 10 commits into
FuelLabs:master
from
tritao:unify-namespaces-parsed-typed
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
added
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
compiler: collection
Everything to do with graph collection, type collection, and the collection context.
labels
May 24, 2024
tritao
force-pushed
the
unify-namespaces-parsed-typed
branch
4 times, most recently
from
May 31, 2024 10:12
6850b32
to
32cac73
Compare
tritao
force-pushed
the
unify-namespaces-parsed-typed
branch
5 times, most recently
from
June 6, 2024 13:37
d6627f1
to
0507e78
Compare
tritao
force-pushed
the
unify-namespaces-parsed-typed
branch
3 times, most recently
from
June 13, 2024 16:34
48bd832
to
2277be3
Compare
tritao
force-pushed
the
unify-namespaces-parsed-typed
branch
from
June 17, 2024 14:15
9ec23d9
to
9bf6039
Compare
IGI-111
approved these changes
Jun 17, 2024
JoshuaBatty
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler: collection
Everything to do with graph collection, type collection, and the collection context.
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR unifies the logic for namespace imports so it works for parsed and typed declarations.
Additionally it collects and handles imports from handling the use statement when collecting.
This allows the soon-to-be-introduced AST resolving pass and collection context to correctly resolve imports.
Checklist
Breaking*
orNew Feature
labels where relevant.