Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnumVariant parsed decl and minor refactors to namespace-related code #6062

Merged
merged 6 commits into from
May 31, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented May 27, 2024

Description

So this adds a new EnumVariant declaration to the parsed tree declaration hierarchy.

This is essentially the same we do for typed declarations, its just used for diagnostics tracking purposes and is going to be used in a following namespace unification PR.

And some minor cleanup commits split off other PRs and ease review and merges.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label May 27, 2024
@tritao tritao self-assigned this May 27, 2024
@tritao tritao force-pushed the refactor-prepare-namespaces branch from 38e7f2b to f73600f Compare May 27, 2024 14:39
@tritao tritao force-pushed the refactor-prepare-namespaces branch from f73600f to c0727bd Compare May 27, 2024 14:40
@tritao tritao marked this pull request as ready for review May 27, 2024 15:02
@tritao tritao requested review from a team May 27, 2024 15:03
@tritao tritao enabled auto-merge (squash) May 27, 2024 15:25
@tritao tritao requested a review from a team May 29, 2024 12:48
@tritao tritao merged commit e1ea67b into FuelLabs:master May 31, 2024
37 checks passed
IGI-111 added a commit that referenced this pull request May 31, 2024
## Description

As title PR, this unifies the different maps we had to represent both
parsed and typed declaration for namespace module symbols.

This simplifies all the code that handles symbols since there is a
single map to represent symbols at all stages in the compiler.

I tried moving all shadowing-related diagnostics to be run on the parsed
declarations but it will only possible to do until the other PR for full
collection/resolving is done. At the moment it leads to out of order
diagnostics which breaks the test. So just left a TODO and will move
those over in a separate PR once its possible to do so.

Depends on #6062.

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: IGI-111 <igi-111@protonmail.com>
Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants