Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only support hover links for vscode #6181

Merged
merged 8 commits into from
Jun 26, 2024
Merged

fix: only support hover links for vscode #6181

merged 8 commits into from
Jun 26, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Jun 25, 2024 •
edited
Loading

Description

Closes #6091

Front end change: FuelLabs/sway-vscode-plugin#187

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel mentioned this pull request Jun 25, 2024
Merged
@sdankel sdankel marked this pull request as ready for review June 25, 2024 05:35
@sdankel sdankel requested a review from a team as a code owner June 25, 2024 05:35
@JoshuaBatty
Copy link
Member

Might be worth opening an issue to add hover support for neovim now that it's vscode only.

JoshuaBatty
JoshuaBatty reviewed Jun 25, 2024
View reviewed changes
sway-lsp/src/config.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Benchmark for 97f39e7

Click to view benchmark
Test Base PR %
code_action 5.0±0.10ms 5.0±0.02ms 0.00%
code_lens 306.8±9.53ns 321.4±9.02ns +4.76%
compile 3.4±0.04s 3.4±0.08s 0.00%
completion 4.6±0.07ms 4.6±0.07ms 0.00%
did_change_with_caching 3.2±0.10s 3.2±0.05s 0.00%
document_symbol 914.9±28.83µs 878.6±41.71µs -3.97%
format 86.3±1.15ms 88.3±1.24ms +2.32%
goto_definition 338.9±11.59µs 333.2±8.81µs -1.68%
highlight 8.7±0.23ms 8.6±0.13ms -1.15%
hover 561.8±8.31µs 557.0±5.27µs -0.85%
idents_at_position 121.5±0.71µs 121.1±0.83µs -0.33%
inlay_hints 634.8±48.52µs 625.9±18.64µs -1.40%
on_enter 460.0±4.01ns 463.6±17.58ns +0.78%
parent_decl_at_position 3.6±0.04ms 3.6±0.04ms 0.00%
prepare_rename 337.5±4.52µs 332.9±5.95µs -1.36%
rename 8.9±0.21ms 8.9±0.17ms 0.00%
semantic_tokens 1247.7±13.70µs 1273.9±13.14µs +2.10%
token_at_position 344.6±2.97µs 334.0±10.33µs -3.08%
tokens_at_position 3.5±0.03ms 3.5±0.04ms 0.00%
tokens_for_file 398.7±1.80µs 403.2±5.79µs +1.13%
traverse 36.9±0.62ms 36.7±0.66ms -0.54%

@sdankel
Copy link
Member Author

sdankel commented Jun 25, 2024 •
edited
Loading

Might be worth opening an issue to add hover support for neovim now that it's vscode only.

Hover still works, this is just removing the links for neovim that weren't working. Opened an issue: #6184

@sdankel sdankel mentioned this pull request Jun 25, 2024
Open
@sdankel sdankel enabled auto-merge (squash) June 25, 2024 18:28
@sdankel sdankel requested a review from JoshuaBatty June 25, 2024 18:37
@github-actions GitHub Actions
Copy link

Benchmark for a6ad6c0

Click to view benchmark
Test Base PR %
code_action 5.1±0.11ms 5.0±0.02ms -1.96%
code_lens 307.9±10.09ns 322.0±10.93ns +4.58%
compile 3.5±0.13s 3.6±0.11s +2.86%
completion 4.6±0.08ms 4.6±0.10ms 0.00%
did_change_with_caching 3.3±0.10s 3.3±0.09s 0.00%
document_symbol 908.3±50.82µs 841.6±15.28µs -7.34%
format 87.7±1.37ms 87.8±1.08ms +0.11%
goto_definition 428.7±5.08µs 336.6±6.65µs -21.48%
highlight 8.7±0.23ms 8.6±0.22ms -1.15%
hover 566.5±7.91µs 561.9±6.25µs -0.81%
idents_at_position 118.0±0.90µs 121.5±1.41µs +2.97%
inlay_hints 625.5±18.98µs 631.6±29.75µs +0.98%
on_enter 465.8±5.13ns 458.6±13.99ns -1.55%
parent_decl_at_position 3.5±0.04ms 3.6±0.05ms +2.86%
prepare_rename 343.0±10.06µs 338.9±8.11µs -1.20%
rename 8.9±0.21ms 9.0±0.75ms +1.12%
semantic_tokens 1273.7±8.24µs 1240.3±9.61µs -2.62%
token_at_position 335.1±3.54µs 339.0±2.31µs +1.16%
tokens_at_position 3.5±0.05ms 3.6±0.02ms +2.86%
tokens_for_file 394.8±1.51µs 403.7±3.80µs +2.25%
traverse 39.0±1.55ms 38.7±1.24ms -0.77%

@github-actions GitHub Actions
Copy link

Benchmark for ec32102

Click to view benchmark
Test Base PR %
code_action 5.1±0.11ms 5.1±0.16ms 0.00%
code_lens 330.2±15.41ns 288.1±17.18ns -12.75%
compile 3.6±0.10s 3.5±0.07s -2.78%
completion 4.7±0.09ms 4.8±0.25ms +2.13%
did_change_with_caching 3.3±0.06s 3.3±0.05s 0.00%
document_symbol 898.5±45.86µs 847.4±43.66µs -5.69%
format 87.8±1.33ms 87.1±1.67ms -0.80%
goto_definition 338.7±10.91µs 337.5±9.33µs -0.35%
highlight 8.7±0.13ms 8.8±0.17ms +1.15%
hover 634.1±7.18µs 563.2±8.68µs -11.18%
idents_at_position 120.4±0.34µs 121.4±0.56µs +0.83%
inlay_hints 635.3±46.04µs 635.7±24.39µs +0.06%
on_enter 490.5±12.97ns 468.6±16.19ns -4.46%
parent_decl_at_position 3.6±0.02ms 3.6±0.02ms 0.00%
prepare_rename 338.0±5.04µs 337.7±7.97µs -0.09%
rename 9.0±0.25ms 9.0±0.29ms 0.00%
semantic_tokens 1277.6±12.77µs 1250.6±14.66µs -2.11%
token_at_position 340.0±2.67µs 334.5±4.26µs -1.62%
tokens_at_position 3.6±0.08ms 3.6±0.03ms 0.00%
tokens_for_file 400.0±1.89µs 395.7±2.56µs -1.08%
traverse 38.8±1.46ms 39.5±0.93ms +1.80%

@sdankel sdankel requested a review from a team June 26, 2024 00:38
@github-actions GitHub Actions
Copy link

Benchmark for 1794207

Click to view benchmark
Test Base PR %
code_action 5.1±0.10ms 5.0±0.10ms -1.96%
code_lens 311.7±8.60ns 284.5±8.46ns -8.73%
compile 2.5±0.02s 2.6±0.06s +4.00%
completion 4.5±0.04ms 4.7±0.13ms +4.44%
did_change_with_caching 2.4±0.03s 2.6±0.04s +8.33%
document_symbol 858.3±22.78µs 865.5±29.09µs +0.84%
format 88.4±0.47ms 87.9±1.11ms -0.57%
goto_definition 342.2±8.00µs 346.7±14.84µs +1.32%
highlight 8.6±0.10ms 8.7±0.06ms +1.16%
hover 497.8±7.71µs 492.5±7.70µs -1.06%
idents_at_position 119.7±2.54µs 121.7±0.64µs +1.67%
inlay_hints 629.5±25.84µs 632.9±24.67µs +0.54%
on_enter 466.4±13.98ns 474.5±13.07ns +1.74%
parent_decl_at_position 3.6±0.05ms 3.6±0.07ms 0.00%
prepare_rename 341.5±11.94µs 343.6±7.83µs +0.61%
rename 9.7±0.06ms 9.1±0.18ms -6.19%
semantic_tokens 1247.3±10.61µs 1273.4±19.11µs +2.09%
token_at_position 335.7±2.01µs 332.3±6.35µs -1.01%
tokens_at_position 3.6±0.02ms 3.6±0.04ms 0.00%
tokens_for_file 396.1±3.20µs 398.9±4.02µs +0.71%
traverse 37.8±1.35ms 38.2±1.00ms +1.06%

JoshuaBatty
JoshuaBatty approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JoshuaBatty JoshuaBatty requested a review from a team June 26, 2024 06:26
@JoshuaBatty JoshuaBatty added the language server LSP server label Jun 26, 2024
@github-actions GitHub Actions
Copy link

Benchmark for 578be81

Click to view benchmark
Test Base PR %
code_action 5.0±0.03ms 5.0±0.04ms 0.00%
code_lens 315.4±2.82ns 284.3±8.81ns -9.86%
compile 2.6±0.03s 2.5±0.03s -3.85%
completion 4.5±0.08ms 4.6±0.10ms +2.22%
did_change_with_caching 2.5±0.02s 2.5±0.03s 0.00%
document_symbol 951.6±29.74µs 903.3±57.12µs -5.08%
format 87.5±0.79ms 88.1±0.87ms +0.69%
goto_definition 334.9±10.23µs 342.5±4.31µs +2.27%
highlight 8.6±0.02ms 8.7±0.14ms +1.16%
hover 491.0±9.03µs 493.0±7.82µs +0.41%
idents_at_position 117.9±0.41µs 121.4±1.86µs +2.97%
inlay_hints 621.6±13.73µs 635.3±24.62µs +2.20%
on_enter 461.6±5.51ns 472.3±12.65ns +2.32%
parent_decl_at_position 3.5±0.03ms 3.6±0.15ms +2.86%
prepare_rename 334.0±7.61µs 346.5±9.45µs +3.74%
rename 8.9±0.12ms 8.9±0.34ms 0.00%
semantic_tokens 1270.7±11.52µs 1239.0±20.32µs -2.49%
token_at_position 342.7±2.86µs 336.1±3.28µs -1.93%
tokens_at_position 3.5±0.02ms 3.6±0.05ms +2.86%
tokens_for_file 438.7±2.72µs 403.8±9.24µs -7.96%
traverse 38.2±0.94ms 38.1±0.85ms -0.26%

@sdankel sdankel merged commit 014e181 into master Jun 26, 2024
38 checks passed
@sdankel sdankel deleted the sophie/6091 branch June 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayagokalp kayagokalp kayagokalp approved these changes

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

Assignees

@sdankel sdankel

Labels
language server LSP server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with neovim hover
3 participants
@sdankel @JoshuaBatty @kayagokalp