Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle traits when doing namespace item imports. #6189

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Jun 25, 2024

This reverts PR #6080 due to a pretty severe performance regression.

The reason this was split to a separate step was because it needs a typed declaration due to the depedency on the type system and thus cannot be used during collection.

However, the type system will be changed to work with parsed declarations pretty soon, so revert this back to the old behavior and temporarily check for a typed declaration instead.

Fixes #6182.

Description

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao self-assigned this Jun 25, 2024
This reverts PR FuelLabs#6080 due to a pretty severe performance regression.

The reason this was split to a separate step was because it needs a
typed declaration due to the depedency on the type system and thus
cannot be used during collection.

However, the type system will be changed to work with parsed
declarations pretty soon, so revert this back to the old behavior and
temporarily check for a typed declaration instead.

Fixes FuelLabs#6182.
@tritao tritao force-pushed the fix-trait-handling-item-import branch from 12a13f3 to 2d05fa5 Compare June 25, 2024 19:41
@tritao tritao marked this pull request as ready for review June 25, 2024 21:03
@tritao tritao requested a review from a team as a code owner June 25, 2024 21:03
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) June 26, 2024 00:05
@JoshuaBatty JoshuaBatty merged commit 2cbc24d into FuelLabs:master Jun 26, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forc@0.61.0 using a lot of RAM during build
3 participants