-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update all the deps #6190
update all the deps #6190
Conversation
return None; | ||
}; | ||
if meta_list.nested.len() != 1 { | ||
let nested = attr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a bit of a struggle but I think I got it to something reasonable. Not sure yet how to confirm that this change is safe.
}], | ||
}; | ||
|
||
let message = AnnotationType::Note.title("").snippet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API for annotate-snippets
changed quite a bit it seems but I did what I could to make things match what the previous code was trying to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rvcas #6187 will update forc-wallet to v0.8.1. Also it might be nice to do this to https://github.com/FuelLabs/sway/tree/master/test/src/sdk-harness as well. This (sdk-harness) is not part of the workspace to prevent some intra repo dependency we have between rust sdk and sway repo. So it is separate from the workspace and if you ran cargo update on root of this workspace, it won't get updated. RC for that for now to prevent getting this merged accidentally but if you already did that and there is no diff let me know, will pull this back!
use tracing::metadata::LevelFilter; | ||
|
||
pub fn handle_initialize( | ||
state: &ServerState, | ||
params: &lsp_types::InitializeParams, | ||
params: &tower_lsp::lsp_types::InitializeParams, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are getting pretty long now. It's probably nicer so either include the type in the use statement directly or use tower_lsp::lsp_types::{self, .... }
to keep these how they were.
#6187 is merged and should help about forc-wallet issue you were having :) |
closing this as it is no longer relevant |
Description
closes #6179
I ran
cargo upgrade
and then had to fix a few things becausesyn
andannotate-snippets
had breaking changes.I can update the
fuel-*
deps as well but some of the errors were a bit cryptic for me still cause I have yet to sort out how all the things glue together.I'm still having some issues with
forc-wallet
which was bumped in the lock file to0.8.1
from0.8.0
.There was some odd version mismatch between
lsp_types
andtower_lsp::lsp_types
. I figured it's probably best to just use thelsp_types
that is re-exported by tower-lsp so that we can avoid the version mismatch entirely.Checklist
Breaking*
orNew Feature
labels where relevant.