Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all the deps #6190

Closed
wants to merge 1 commit into from
Closed

update all the deps #6190

wants to merge 1 commit into from

Conversation

rvcas
Copy link

@rvcas rvcas commented Jun 25, 2024

Description

closes #6179

I ran cargo upgrade and then had to fix a few things because syn and annotate-snippets had breaking changes.

I can update the fuel-* deps as well but some of the errors were a bit cryptic for me still cause I have yet to sort out how all the things glue together.

I'm still having some issues with forc-wallet which was bumped in the lock file to 0.8.1 from 0.8.0.

There was some odd version mismatch between lsp_types and tower_lsp::lsp_types. I figured it's probably best to just use the lsp_types that is re-exported by tower-lsp so that we can avoid the version mismatch entirely.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@rvcas rvcas requested review from a team as code owners June 25, 2024 20:04
return None;
};
if meta_list.nested.len() != 1 {
let nested = attr
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bit of a struggle but I think I got it to something reasonable. Not sure yet how to confirm that this change is safe.

}],
};

let message = AnnotationType::Note.title("").snippet(
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API for annotate-snippets changed quite a bit it seems but I did what I could to make things match what the previous code was trying to do.

Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rvcas #6187 will update forc-wallet to v0.8.1. Also it might be nice to do this to https://github.com/FuelLabs/sway/tree/master/test/src/sdk-harness as well. This (sdk-harness) is not part of the workspace to prevent some intra repo dependency we have between rust sdk and sway repo. So it is separate from the workspace and if you ran cargo update on root of this workspace, it won't get updated. RC for that for now to prevent getting this merged accidentally but if you already did that and there is no diff let me know, will pull this back!

use tracing::metadata::LevelFilter;

pub fn handle_initialize(
state: &ServerState,
params: &lsp_types::InitializeParams,
params: &tower_lsp::lsp_types::InitializeParams,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are getting pretty long now. It's probably nicer so either include the type in the use statement directly or use tower_lsp::lsp_types::{self, .... } to keep these how they were.

@kayagokalp
Copy link
Member

#6187 is merged and should help about forc-wallet issue you were having :)

@JoshuaBatty JoshuaBatty marked this pull request as draft July 18, 2024 00:10
@kayagokalp
Copy link
Member

closing this as it is no longer relevant

@kayagokalp kayagokalp closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all deps to be the latest version across the whole repo
3 participants