Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Output::ContractCreated transaction to Output enum #6194

Merged
merged 17 commits into from
Jul 12, 2024
Merged

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Jun 27, 2024

Description

The Output enum did not have the ContractCreated variant. This has been added as well as a test to ensure this output type is returned when a contact is deployed with a predicate in the inputs.

Eq for Output has also been added.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic added lib: std Standard library breaking May cause existing user code to break. Requires a minor or major release. labels Jun 27, 2024
@bitzoic bitzoic self-assigned this Jun 27, 2024
@bitzoic bitzoic requested review from a team as code owners June 27, 2024 09:01
@bitzoic bitzoic linked an issue Jun 27, 2024 that may be closed by this pull request
jjcnn
jjcnn previously approved these changes Jul 8, 2024
@K1-R1 K1-R1 requested a review from a team July 11, 2024 21:49
@bitzoic bitzoic merged commit b92c7a2 into master Jul 12, 2024
38 checks passed
@bitzoic bitzoic deleted the bitzoic-6130 branch July 12, 2024 09:55
esdrubal pushed a commit that referenced this pull request Aug 13, 2024
## Description

The `Output` enum did not have the `ContractCreated` variant. This has
been added as well as a test to ensure this output type is returned when
a contact is deployed with a predicate in the inputs.

`Eq` for `Output` has also been added.

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking May cause existing user code to break. Requires a minor or major release. lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Output::ContractCreated transaction to Output enum
4 participants