Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables tests that prove #418 is solved. #6206

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Enables tests that prove #418 is solved. #6206

merged 2 commits into from
Jul 2, 2024

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Jul 1, 2024 •
edited
Loading

Description

Two disabled tests preventing #418 from being closed, are now fixed.

Closes #418

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal esdrubal added the compiler General compiler. Should eventually become more specific as the issue is triaged label Jul 1, 2024
@esdrubal esdrubal self-assigned this Jul 1, 2024
@esdrubal
Enables tests that prove #418 is solved.
f856463 
Two disabled tests preventing #418 from being closed, are now fixed.

Closes #418
@esdrubal esdrubal marked this pull request as ready for review July 1, 2024 22:37
@esdrubal esdrubal requested a review from a team as a code owner July 1, 2024 22:37
@JoshuaBatty JoshuaBatty requested a review from a team July 1, 2024 23:37
@IGI-111 IGI-111 enabled auto-merge (squash) July 2, 2024 11:09
@IGI-111 IGI-111 merged commit 5465ca3 into master Jul 2, 2024
34 checks passed
@IGI-111 IGI-111 deleted the esdrubal/418 branch July 2, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@tritao tritao tritao approved these changes

Assignees

@esdrubal esdrubal

Labels
compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unification unifies different but identical types
4 participants
@esdrubal @tritao @JoshuaBatty @IGI-111