Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core and std dependency test filtering to the test runner #6299

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Jul 25, 2024

Description

This adds a couple new flags to the test runner which allow filtering the tests to exclude them if they contain a dependency on either core or std.

This is useful to debug issues, since it allows to run tests without any dependencies, making debugging a bit less difficult when dealing with complicated issues.

There is also a minor refactoring to BuildPlan::from_build_opts which I thought was necessary, but ended up not being used, but I think doesnt hurt to keep.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added the testing General testing label Jul 25, 2024
@tritao tritao self-assigned this Jul 25, 2024
These flags allow to exclude tests if they depend on either `core` or
`std` dependencies.
@tritao tritao force-pushed the test-filter-core-std branch from 0019813 to 19c3929 Compare July 26, 2024 15:42
@tritao tritao added the enhancement New feature or request label Jul 26, 2024
@tritao tritao marked this pull request as ready for review July 26, 2024 16:25
@tritao tritao requested review from a team as code owners July 26, 2024 16:25
@tritao tritao enabled auto-merge (squash) July 26, 2024 16:25
@JoshuaBatty JoshuaBatty requested review from a team July 29, 2024 23:38
@tritao tritao merged commit 98dc591 into FuelLabs:master Jul 30, 2024
39 checks passed
esdrubal pushed a commit that referenced this pull request Aug 13, 2024
)

## Description

This adds a couple new flags to the test runner which allow filtering
the tests to exclude them if they contain a dependency on either `core`
or `std`.

This is useful to debug issues, since it allows to run tests without any
dependencies, making debugging a bit less difficult when dealing with
complicated issues.

There is also a minor refactoring to `BuildPlan::from_build_opts` which
I thought was necessary, but ended up not being used, but I think doesnt
hurt to keep.

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing General testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants