Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for slice new syntax &[T] #6307

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Support for slice new syntax &[T] #6307

merged 3 commits into from
Aug 5, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Jul 29, 2024

Description

Part of #5110.

This PR implements supports for the slice new syntax: &[T]. The old syntax is still supported and will be deprecated in a future PR.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj self-assigned this Jul 29, 2024
@xunilrj xunilrj requested review from a team as code owners July 29, 2024 11:00
@xunilrj xunilrj mentioned this pull request Jul 29, 2024
17 tasks
JoshuaBatty
JoshuaBatty previously approved these changes Jul 29, 2024
@JoshuaBatty JoshuaBatty requested review from a team July 29, 2024 23:33
@JoshuaBatty JoshuaBatty requested review from a team August 1, 2024 09:42
@xunilrj xunilrj force-pushed the xunilrj/slice-new-syntax branch from a1011d8 to 9141055 Compare August 2, 2024 09:01
@IGI-111 IGI-111 merged commit da0caf9 into master Aug 5, 2024
38 checks passed
@IGI-111 IGI-111 deleted the xunilrj/slice-new-syntax branch August 5, 2024 07:52
esdrubal pushed a commit that referenced this pull request Aug 13, 2024
## Description

Part of #5110.

This PR implements supports for the slice new syntax: `&[T]`. The old
syntax is still supported and will be deprecated in a future PR.

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants