-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix range OOB bug in the language server #6314
Merged
Merged
+152
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
force-pushed
the
josh/text_document
branch
from
July 30, 2024 00:22
8d6bb55
to
98e7590
Compare
JoshuaBatty
force-pushed
the
josh/text_document
branch
from
July 30, 2024 00:25
d9a9f2c
to
48f9a6b
Compare
Benchmark for ecb2644Click to view benchmark
|
JoshuaBatty
force-pushed
the
josh/text_document
branch
from
July 30, 2024 01:26
cd62efd
to
6e2102a
Compare
Benchmark for 5b2b5a2Click to view benchmark
|
Benchmark for 1ba0fbbClick to view benchmark
|
Benchmark for 1349a26Click to view benchmark
|
sdankel
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a 300% increase in the benchmark for on_enter, but it's still only 2 microseconds total, which is acceptable. Looks good to me!
Benchmark for e475a13Click to view benchmark
|
kayagokalp
approved these changes
Jul 31, 2024
Benchmark for 98bca02Click to view benchmark
|
IGI-111
approved these changes
Jul 31, 2024
esdrubal
pushed a commit
that referenced
this pull request
Aug 13, 2024
## Description This PR fixes a crash in the language server caused by an out-of-bounds error when using `rope`. It replaces the `ropey` crate with a custom implementation using `String` and `Vec<usize>` for line offsets. This change improves robustness and prevents panics when handling rapid text changes. Closes #6313 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a crash in the language server caused by an out-of-bounds error when using
rope
. It replaces theropey
crate with a custom implementation usingString
andVec<usize>
for line offsets. This change improves robustness and prevents panics when handling rapid text changes.Closes #6313
Checklist
Breaking*
orNew Feature
labels where relevant.