Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in memcpyopt #6359

Merged
merged 27 commits into from
Aug 9, 2024
Merged

Fix bugs in memcpyopt #6359

merged 27 commits into from
Aug 9, 2024

Conversation

vaivaswatha
Copy link
Contributor

@vaivaswatha vaivaswatha commented Aug 5, 2024

Description

Fixes #6321
Fixes #6360
Fixes #6361

@vaivaswatha vaivaswatha self-assigned this Aug 5, 2024
@vaivaswatha vaivaswatha marked this pull request as ready for review August 6, 2024 09:31
@vaivaswatha vaivaswatha requested review from a team as code owners August 6, 2024 09:31
IGI-111
IGI-111 previously approved these changes Aug 6, 2024
@IGI-111 IGI-111 requested a review from a team August 6, 2024 12:51
@vaivaswatha vaivaswatha changed the title Fix bug in memcpyopt and do it always for non-copy types Fix bugs in memcpyopt Aug 7, 2024
@vaivaswatha
Copy link
Contributor Author

I've pushed another commit that fixes another bug in the same optimization.

IGI-111
IGI-111 previously approved these changes Aug 7, 2024
@IGI-111 IGI-111 requested a review from a team August 7, 2024 09:43
@vaivaswatha vaivaswatha enabled auto-merge (squash) August 8, 2024 03:12
@vaivaswatha vaivaswatha requested a review from IGI-111 August 8, 2024 03:12
IGI-111
IGI-111 previously approved these changes Aug 8, 2024
@IGI-111 IGI-111 requested a review from a team August 8, 2024 08:22
sdankel
sdankel previously approved these changes Aug 8, 2024
@vaivaswatha vaivaswatha dismissed stale reviews from sdankel and IGI-111 via 1b91fbe August 9, 2024 07:49
@IGI-111 IGI-111 requested review from sdankel and a team August 9, 2024 07:53
@vaivaswatha vaivaswatha merged commit 3ade41c into master Aug 9, 2024
38 checks passed
@vaivaswatha vaivaswatha deleted the vaivaswatha/issue6321 branch August 9, 2024 11:56
esdrubal pushed a commit that referenced this pull request Aug 13, 2024
## Description

Fixes  #6321
Fixes #6360
Fixes #6361

---------

Co-authored-by: IGI-111 <igi-111@protonmail.com>
Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory-write-overlap bug Infinite loop in memcpyopt Incorrect load_store_to_memcopy optimization
4 participants