Fixes crash on encode_buffer_append with wrong args. #6365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encode_buffer_append was called with wrong number of args an array OOB panick was thrown. With this fix we throw a CompileError::IntrinsicIncorrectNumArgs in case the intrinsic encode_buffer_append is called with more or less than the expected 2 arguments. Fixes #6337
esdrubal
added
bug
Benchmark for 86682f1Click to view benchmark
|
IGI-111
approved these changes
Aug 7, 2024
tritao
approved these changes
Aug 7, 2024
Benchmark for 7bd877bClick to view benchmark
|
Benchmark for 26d67caClick to view benchmark
|
esdrubal
added a commit
that referenced
this pull request
Aug 13, 2024
## Description When encode_buffer_append was called with a wrong number of args an array OOB panic was thrown. With this fix we throw a CompileError::IntrinsicIncorrectNumArgs in case the intrinsic encode_buffer_append is called with more or less than the expected 2 arguments. Fixes #6337 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. Co-authored-by: João Matos <joao@tritao.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When encode_buffer_append was called with a wrong number of args an array OOB panic was thrown.
With this fix we throw a CompileError::IntrinsicIncorrectNumArgs in case the intrinsic encode_buffer_append is called with more or less than the expected 2 arguments.
Fixes #6337
Checklist
Breaking*orNew Featurelabels where relevant.