Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken documentation link #6400

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Fix broken documentation link #6400

merged 4 commits into from
Aug 9, 2024

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented Aug 7, 2024

Description

Closes #6392

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 requested a review from a team as a code owner August 7, 2024 10:41
Copy link

github-actions bot commented Aug 7, 2024

Benchmark for 9abd780

Click to view benchmark
Test Base PR %
code_action 5.1±0.18ms 5.1±0.20ms 0.00%
code_lens 307.8±13.91ns 314.3±22.35ns +2.11%
compile 3.0±0.10s 3.2±0.07s +6.67%
completion 4.8±0.23ms 4.6±0.03ms -4.17%
did_change_with_caching 3.1±0.11s 3.1±0.07s 0.00%
document_symbol 997.9±59.90µs 1049.7±69.39µs +5.19%
format 73.2±1.33ms 75.8±3.55ms +3.55%
goto_definition 353.4±9.93µs 345.7±7.64µs -2.18%
highlight 9.0±0.16ms 8.7±0.28ms -3.33%
hover 519.8±12.68µs 511.7±8.45µs -1.56%
idents_at_position 128.8±2.12µs 122.0±2.63µs -5.28%
inlay_hints 645.2±16.17µs 661.9±47.21µs +2.59%
on_enter 1928.1±38.57ns 2.0±0.10µs +3.73%
parent_decl_at_position 3.7±0.09ms 3.7±0.07ms 0.00%
prepare_rename 349.9±11.13µs 348.5±14.46µs -0.40%
rename 9.1±0.36ms 8.9±0.03ms -2.20%
semantic_tokens 1238.4±24.16µs 1313.9±28.01µs +6.10%
token_at_position 358.4±7.36µs 346.8±3.94µs -3.24%
tokens_at_position 3.7±0.07ms 3.6±0.05ms -2.70%
tokens_for_file 429.4±7.50µs 419.0±7.33µs -2.42%
traverse 49.6±3.01ms 52.7±3.25ms +6.25%

@IGI-111 IGI-111 self-assigned this Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Benchmark for 32b98b7

Click to view benchmark
Test Base PR %
code_action 5.1±0.11ms 5.1±0.08ms 0.00%
code_lens 286.5±8.93ns 285.4±7.27ns -0.38%
compile 2.7±0.04s 2.6±0.05s -3.70%
completion 4.5±0.02ms 4.6±0.01ms +2.22%
did_change_with_caching 2.6±0.03s 2.6±0.02s 0.00%
document_symbol 929.9±26.47µs 864.8±27.87µs -7.00%
format 74.4±1.25ms 73.0±1.06ms -1.88%
goto_definition 345.8±6.92µs 346.1±6.37µs +0.09%
highlight 8.7±0.05ms 8.7±0.16ms 0.00%
hover 498.1±6.79µs 502.7±12.80µs +0.92%
idents_at_position 118.2±1.16µs 119.8±0.67µs +1.35%
inlay_hints 630.7±29.46µs 638.9±25.19µs +1.30%
on_enter 1880.5±40.01ns 2.1±0.05µs +11.67%
parent_decl_at_position 3.6±0.19ms 3.5±0.04ms -2.78%
prepare_rename 348.1±9.41µs 349.8±6.95µs +0.49%
rename 9.0±0.20ms 9.0±0.16ms 0.00%
semantic_tokens 1289.9±13.80µs 1206.8±15.61µs -6.44%
token_at_position 335.5±3.12µs 339.7±2.73µs +1.25%
tokens_at_position 3.6±0.02ms 3.5±0.04ms -2.78%
tokens_for_file 395.5±2.53µs 393.4±1.74µs -0.53%
traverse 38.4±1.12ms 37.7±1.21ms -1.82%

Copy link

github-actions bot commented Aug 7, 2024

Benchmark for ce7deb4

Click to view benchmark
Test Base PR %
code_action 5.2±0.11ms 5.2±0.11ms 0.00%
code_lens 288.8±10.67ns 286.6±8.85ns -0.76%
compile 2.7±0.04s 2.7±0.06s 0.00%
completion 4.7±0.11ms 4.7±0.41ms 0.00%
did_change_with_caching 2.7±0.03s 2.7±0.02s 0.00%
document_symbol 914.7±40.63µs 990.1±34.46µs +8.24%
format 72.5±0.91ms 73.0±1.21ms +0.69%
goto_definition 343.8±6.26µs 345.4±8.07µs +0.47%
highlight 9.0±0.15ms 8.9±0.02ms -1.11%
hover 499.6±7.41µs 499.1±6.43µs -0.10%
idents_at_position 116.8±0.29µs 117.5±0.77µs +0.60%
inlay_hints 639.5±14.28µs 648.8±27.48µs +1.45%
on_enter 2.0±0.07µs 1977.5±82.97ns -1.12%
parent_decl_at_position 3.7±0.04ms 3.7±0.07ms 0.00%
prepare_rename 342.1±3.81µs 344.8±7.97µs +0.79%
rename 9.3±0.18ms 9.3±0.17ms 0.00%
semantic_tokens 1231.1±10.64µs 1260.2±10.90µs +2.36%
token_at_position 332.6±3.09µs 341.8±2.45µs +2.77%
tokens_at_position 3.7±0.04ms 3.7±0.03ms 0.00%
tokens_for_file 402.2±2.45µs 400.4±2.71µs -0.45%
traverse 38.4±1.29ms 38.8±0.76ms +1.04%

Copy link

github-actions bot commented Aug 8, 2024

Benchmark for 42e2783

Click to view benchmark
Test Base PR %
code_action 5.2±0.07ms 5.3±0.14ms +1.92%
code_lens 285.0±8.01ns 285.4±3.58ns +0.14%
compile 2.7±0.05s 2.7±0.06s 0.00%
completion 4.8±0.09ms 4.8±0.14ms 0.00%
did_change_with_caching 2.7±0.03s 2.6±0.07s -3.70%
document_symbol 866.9±12.60µs 905.7±39.37µs +4.48%
format 72.5±0.85ms 73.6±1.22ms +1.52%
goto_definition 336.5±5.15µs 338.0±5.92µs +0.45%
highlight 9.1±0.04ms 9.2±0.51ms +1.10%
hover 491.0±6.06µs 493.4±9.53µs +0.49%
idents_at_position 119.4±0.36µs 119.5±0.87µs +0.08%
inlay_hints 634.2±9.07µs 641.5±19.03µs +1.15%
on_enter 2.0±0.05µs 2.0±0.04µs 0.00%
parent_decl_at_position 3.7±0.04ms 3.8±0.08ms +2.70%
prepare_rename 383.7±5.88µs 341.1±10.65µs -11.10%
rename 9.5±0.12ms 9.5±0.20ms 0.00%
semantic_tokens 1236.1±18.62µs 1277.0±28.53µs +3.31%
token_at_position 336.0±1.85µs 334.8±2.69µs -0.36%
tokens_at_position 3.7±0.03ms 3.7±0.03ms 0.00%
tokens_for_file 397.4±2.68µs 399.0±2.98µs +0.40%
traverse 37.5±0.71ms 37.6±1.25ms +0.27%

@tritao tritao merged commit 273bc14 into master Aug 9, 2024
39 checks passed
@tritao tritao deleted the IGI-111/docs-link branch August 9, 2024 09:32
esdrubal pushed a commit that referenced this pull request Aug 13, 2024
## Description

Closes #6392

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Link in usefulness.rs Does Not Refer to a Valid Location
3 participants