-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes panic on unwrapping in type_check_trait_implementation. #6434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
added
bug
Something isn't working
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
labels
Aug 19, 2024
This PR fixes panic on unwrapping by only perform the required behaviour with the unwrapped value when it is available. Fixes #6336
esdrubal
force-pushed
the
esdrubal/6336_2
branch
from
August 19, 2024 13:39
8219fd7
to
f084ed2
Compare
Benchmark for 76bcf6cClick to view benchmark
|
tritao
approved these changes
Aug 20, 2024
sdankel
approved these changes
Aug 20, 2024
Benchmark for a960996Click to view benchmark
|
Benchmark for e8f1d05Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes panic on unwrapping by only performing the required behavior with the unwrapped value when it is available.
Fixes #6336
Checklist
Breaking*
orNew Feature
labels where relevant.