Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle formatting new types in StorageField #6451

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Handle formatting new types in StorageField #6451

merged 3 commits into from
Aug 26, 2024

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Aug 22, 2024 •
edited
Loading

Description

closes #6447

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty requested review from a team as code owners August 22, 2024 02:56
@JoshuaBatty JoshuaBatty self-assigned this Aug 22, 2024
@JoshuaBatty JoshuaBatty added bug Something isn't working formatter labels Aug 22, 2024
@JoshuaBatty JoshuaBatty marked this pull request as draft August 22, 2024 02:56
alfiedotwtf
alfiedotwtf previously approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@alfiedotwtf alfiedotwtf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the StorageField changes. Will review #6450 now

@JoshuaBatty JoshuaBatty marked this pull request as ready for review August 24, 2024 23:07
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) August 24, 2024 23:08
kayagokalp
kayagokalp approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@JoshuaBatty JoshuaBatty requested a review from a team August 25, 2024 03:05
@JoshuaBatty JoshuaBatty merged commit d7154b1 into master Aug 26, 2024
38 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/formatter_bug branch August 26, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayagokalp kayagokalp kayagokalp approved these changes

@alfiedotwtf alfiedotwtf alfiedotwtf approved these changes

Assignees

@JoshuaBatty JoshuaBatty

Labels
bug Something isn't working formatter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forc-fmt: removes in keyword
3 participants
@JoshuaBatty @alfiedotwtf @kayagokalp