Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove comment #6463

Merged
merged 4 commits into from
Aug 24, 2024
Merged

chore: remove comment #6463

merged 4 commits into from
Aug 24, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Aug 23, 2024

Description

Closes #6209
It looks like the compiler actually doesn't cache anything between builds, so this issue can be closed.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review August 23, 2024 23:02
@sdankel sdankel requested review from a team as code owners August 23, 2024 23:02
@sdankel sdankel enabled auto-merge (squash) August 23, 2024 23:03
Copy link

Benchmark for 1a0c5fa

Click to view benchmark
Test Base PR %
code_action 5.3±0.38ms 5.3±0.01ms 0.00%
code_lens 285.6±5.10ns 286.8±10.26ns +0.42%
compile 2.7±0.04s 2.7±0.07s 0.00%
completion 4.7±0.04ms 4.7±0.08ms 0.00%
did_change_with_caching 2.6±0.04s 2.6±0.03s 0.00%
document_symbol 941.4±32.23µs 933.3±44.70µs -0.86%
format 69.9±0.89ms 69.7±0.75ms -0.29%
goto_definition 341.9±2.96µs 338.0±5.76µs -1.14%
highlight 9.1±0.02ms 9.1±0.05ms 0.00%
hover 494.4±5.57µs 496.5±6.47µs +0.42%
idents_at_position 117.9±0.22µs 117.5±1.24µs -0.34%
inlay_hints 640.5±10.90µs 646.1±19.19µs +0.87%
on_enter 2.0±0.02µs 2.0±0.04µs 0.00%
parent_decl_at_position 3.7±0.03ms 3.7±0.03ms 0.00%
prepare_rename 341.9±6.58µs 336.6±4.32µs -1.55%
rename 9.5±0.50ms 9.4±0.10ms -1.05%
semantic_tokens 1216.5±9.56µs 1207.7±55.56µs -0.72%
token_at_position 337.3±1.45µs 331.6±3.37µs -1.69%
tokens_at_position 3.7±0.15ms 3.7±0.03ms 0.00%
tokens_for_file 407.3±3.89µs 406.6±2.67µs -0.17%
traverse 34.1±0.59ms 34.2±0.56ms +0.29%

@JoshuaBatty JoshuaBatty requested a review from a team August 24, 2024 00:13
Copy link

Benchmark for 97b6aa3

Click to view benchmark
Test Base PR %
code_action 5.5±0.19ms 5.4±0.02ms -1.82%
code_lens 284.7±5.49ns 286.5±19.97ns +0.63%
compile 2.9±0.08s 2.7±0.07s -6.90%
completion 4.9±0.18ms 4.7±0.04ms -4.08%
did_change_with_caching 2.7±0.05s 2.6±0.03s -3.70%
document_symbol 888.8±37.78µs 896.0±27.42µs +0.81%
format 71.3±2.56ms 70.5±1.05ms -1.12%
goto_definition 335.5±8.79µs 352.8±9.33µs +5.16%
highlight 9.1±0.15ms 9.1±0.08ms 0.00%
hover 489.3±6.46µs 504.9±6.20µs +3.19%
idents_at_position 118.2±1.67µs 117.9±1.05µs -0.25%
inlay_hints 625.7±22.25µs 643.6±23.59µs +2.86%
on_enter 1920.4±19.34ns 2.1±0.04µs +9.35%
parent_decl_at_position 3.7±0.05ms 3.6±0.01ms -2.70%
prepare_rename 331.3±7.07µs 352.5±9.58µs +6.40%
rename 9.6±0.18ms 9.4±0.11ms -2.08%
semantic_tokens 1261.0±24.21µs 1234.5±16.37µs -2.10%
token_at_position 336.1±2.51µs 342.0±2.14µs +1.76%
tokens_at_position 3.6±0.02ms 3.7±0.05ms +2.78%
tokens_for_file 399.6±3.44µs 399.6±2.60µs 0.00%
traverse 35.5±0.97ms 34.9±0.73ms -1.69%

@sdankel sdankel merged commit 4af5cd5 into master Aug 24, 2024
38 checks passed
@sdankel sdankel deleted the sophie/6209 branch August 24, 2024 01:44
Copy link

Benchmark for 9aa14b7

Click to view benchmark
Test Base PR %
code_action 5.1±0.07ms 5.1±0.04ms 0.00%
code_lens 286.0±14.20ns 286.2±12.11ns +0.07%
compile 2.7±0.07s 2.6±0.05s -3.70%
completion 4.5±0.08ms 4.6±0.04ms +2.22%
did_change_with_caching 2.6±0.05s 2.6±0.03s 0.00%
document_symbol 904.2±43.54µs 853.2±19.94µs -5.64%
format 70.4±0.92ms 70.9±1.24ms +0.71%
goto_definition 335.8±3.62µs 341.1±6.10µs +1.58%
highlight 8.7±0.12ms 8.7±0.12ms 0.00%
hover 489.6±4.99µs 492.0±7.28µs +0.49%
idents_at_position 119.3±0.22µs 117.8±1.27µs -1.26%
inlay_hints 626.5±13.59µs 627.3±11.50µs +0.13%
on_enter 1991.1±69.76ns 2.1±0.05µs +5.47%
parent_decl_at_position 3.6±0.10ms 3.6±0.04ms 0.00%
prepare_rename 339.1±6.50µs 340.5±5.11µs +0.41%
rename 9.0±0.15ms 9.0±0.06ms 0.00%
semantic_tokens 1210.1±57.22µs 1252.4±61.95µs +3.50%
token_at_position 332.2±2.74µs 333.5±2.22µs +0.39%
tokens_at_position 3.6±0.03ms 3.6±0.04ms 0.00%
tokens_for_file 397.9±2.27µs 400.8±1.97µs +0.73%
traverse 33.8±0.68ms 34.0±1.26ms +0.59%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only print "Compiling" when the dependency is not already compiled.
3 participants