-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize TokenMap
updates and traversals for modified files only
#6464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
added
language server
LSP server
performance
Everything related to performance, speed wise or memory wise.
labels
Aug 24, 2024
JoshuaBatty
force-pushed
the
josh/token_map_optimisations
branch
from
August 24, 2024 23:23
eec4426
to
40fd25c
Compare
Benchmark for fdbb9f9Click to view benchmark
|
Benchmark for 22e6c71Click to view benchmark
|
sdankel
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 👍
Benchmark for 45418bdClick to view benchmark
|
alfiedotwtf
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
language server
LSP server
performance
Everything related to performance, speed wise or memory wise.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces significant optimisations in how we handle
TokenMap
updates and file traversals, resulting in substantial performance improvements.Key Changes:
TokenMap
on each keystroke, we now only clear tokens belonging to the modified file.Performance Impact:
These optimisations have led to substantial improvements in traverse times, particularly for subsequent traversals:
closes #6292
related to #5445
Checklist
Breaking*
orNew Feature
labels where relevant.