Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix array element type algorithm to avoid selecting never #6511

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Sep 7, 2024

Description

This PR fixes the array element type selection algorithm to avoid selecting Never.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj requested a review from a team as a code owner September 7, 2024 08:38
Copy link

codspeed-hq bot commented Sep 7, 2024

CodSpeed Performance Report

Merging #6511 will not alter performance

Comparing xunilrj/fix-array-elem-type-alg (c8d5155) with master (1d50da1)

Summary

✅ 22 untouched benchmarks

@xunilrj xunilrj requested a review from jjcnn September 10, 2024 14:57
@xunilrj xunilrj force-pushed the xunilrj/fix-array-elem-type-alg branch from 72a6512 to 7d2e15f Compare September 16, 2024 10:47
@IGI-111 IGI-111 enabled auto-merge (squash) September 23, 2024 05:10
@IGI-111 IGI-111 merged commit 3f163c7 into master Sep 23, 2024
38 checks passed
@IGI-111 IGI-111 deleted the xunilrj/fix-array-elem-type-alg branch September 23, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants