-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inlay hints for function parameters #6513
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #6513 will degrade performances by 82.78%Comparing Summary
Benchmarks breakdown
|
alfiedotwtf
previously approved these changes
Sep 9, 2024
JoshuaBatty
force-pushed
the
josh/inlay_hints_function_params
branch
from
September 19, 2024 23:47
d2af314
to
604cf5b
Compare
JoshuaBatty
force-pushed
the
josh/inlay_hints_function_params
branch
3 times, most recently
from
September 21, 2024 00:50
f24baf1
to
aae7ad7
Compare
…plications and variable declarations.
JoshuaBatty
force-pushed
the
josh/inlay_hints_function_params
branch
from
September 21, 2024 01:18
aae7ad7
to
bc1f7f9
Compare
alfiedotwtf
reviewed
Sep 23, 2024
alfiedotwtf
reviewed
Sep 23, 2024
alfiedotwtf
approved these changes
Sep 23, 2024
IGI-111
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inlay hints are now displayed in function parameter locations if a variable with the same name is not present. This should be identical to the behaviour of rust-analyzer. The inlay_hints benchmark is slower because we are now also calculating inlay hints for function_params and variable decls in the same iteration. See screen shot below for all supported types.
closes #5196
Checklist
Breaking*
orNew Feature
labels where relevant.