Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix second pass of method application arguments #6526

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Sep 10, 2024

Description

This PR fixes #6487.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj requested a review from a team as a code owner September 10, 2024 13:11
Copy link

codspeed-hq bot commented Sep 10, 2024

CodSpeed Performance Report

Merging #6526 will degrade performances by 17.72%

Comparing xunilrj/fix-second-pass-unification-method-args (c284bfd) with master (09a992f)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master xunilrj/fix-second-pass-unification-method-args Change
document_symbol 4.3 ms 5.3 ms -17.72%

@xunilrj xunilrj requested a review from a team as a code owner September 10, 2024 15:28
@xunilrj xunilrj force-pushed the xunilrj/fix-second-pass-unification-method-args branch from 5ad72d0 to 88afac8 Compare September 10, 2024 18:31
@IGI-111 IGI-111 requested review from sdankel and a team September 10, 2024 18:34
@xunilrj xunilrj self-assigned this Sep 11, 2024
@xunilrj xunilrj force-pushed the xunilrj/fix-second-pass-unification-method-args branch from 81699cd to c284bfd Compare September 11, 2024 12:32
@xunilrj xunilrj enabled auto-merge (squash) September 11, 2024 12:54
@xunilrj xunilrj merged commit 439f935 into master Sep 11, 2024
37 checks passed
@xunilrj xunilrj deleted the xunilrj/fix-second-pass-unification-method-args branch September 11, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type inference regression for Vec in forc 0.62.0+
4 participants