Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check non-parent monomorphization args #6549

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Sep 16, 2024

Description

This PR fixes #6384

The performance improvement is probably coming from just aggregating spans when there is an error.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Copy link

codspeed-hq bot commented Sep 16, 2024

CodSpeed Performance Report

Merging #6549 will improve performances by 18.83%

Comparing xunilrj/check-monomorphization-non-parent-only (0705c89) with master (520bfe9)

Summary

⚡ 1 improvements
✅ 21 untouched benchmarks

Benchmarks breakdown

Benchmark master xunilrj/check-monomorphization-non-parent-only Change
inlay_hints 3.8 ms 3.2 ms +18.83%

@xunilrj xunilrj marked this pull request as ready for review September 16, 2024 11:06
@xunilrj xunilrj requested a review from a team as a code owner September 16, 2024 11:06
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) September 18, 2024 00:30
@JoshuaBatty JoshuaBatty merged commit e82c72b into master Sep 18, 2024
39 checks passed
@JoshuaBatty JoshuaBatty deleted the xunilrj/check-monomorphization-non-parent-only branch September 18, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generics for Structs and Functions
3 participants