Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement initial support for source mapping #656

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Implement initial support for source mapping #656

merged 2 commits into from
Jan 28, 2022

Conversation

Dentosal
Copy link
Member

Dumps a simple source map to a JSON file

@Dentosal Dentosal self-assigned this Jan 17, 2022
@Dentosal Dentosal marked this pull request as ready for review January 17, 2022 17:55
@Dentosal Dentosal requested a review from sezna as a code owner January 17, 2022 17:55
@adlerjohn adlerjohn added compiler General compiler. Should eventually become more specific as the issue is triaged enhancement New feature or request forc labels Jan 17, 2022
@sezna
Copy link
Contributor

sezna commented Jan 19, 2022

This may change a bit when IR lands, but otherwise LGTM. @Dentosal there are some merge conflicts.

@adlerjohn
Copy link
Contributor

cc @sezna for re-review

adlerjohn
adlerjohn reviewed Jan 22, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts

@Dentosal
Copy link
Member Author

Dentosal commented Jan 24, 2022 •
edited
Loading

Blocked by #696 unblocked

@adlerjohn
Copy link
Contributor

Does this close #70?

@Dentosal
Copy link
Member Author

Not completely. This makes good progress towards #70, but some aspects like memory/variable watching are not available with this.

@adlerjohn adlerjohn mentioned this pull request Jan 25, 2022
Closed
3 tasks
sezna
sezna approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good start.

@sezna sezna merged commit 589db6f into master Jan 28, 2022
@sezna sezna deleted the source-map branch January 28, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn left review comments

@sezna sezna sezna approved these changes

Assignees

@Dentosal Dentosal

Labels
compiler General compiler. Should eventually become more specific as the issue is triaged enhancement New feature or request forc
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dentosal @sezna @adlerjohn