Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all crate dependencies to the workspace Cargo.toml (#6179) #6563

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

alfiedotwtf
Copy link
Contributor

@alfiedotwtf alfiedotwtf commented Sep 18, 2024

Description

For #6179, PR #6501 kept bumping into errors as it was doing too many things, so I've split that PR into multiple PRs. This is the first, and the only thing it does is move all of the various Cargo.toml dependencies into the single workspace Cargo.toml.

Future PRs will:

  • Update dependency versions
  • Update code that breaks from the version bumps

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@alfiedotwtf alfiedotwtf added ci code quality dependencies dev-experience Anything to do with the developer experience labels Sep 18, 2024
@alfiedotwtf alfiedotwtf self-assigned this Sep 18, 2024
@alfiedotwtf alfiedotwtf requested review from a team as code owners September 18, 2024 07:19
@alfiedotwtf alfiedotwtf force-pushed the alfie/minimal-cargo-workspace-changes branch from f103f14 to dd9cdec Compare September 18, 2024 07:21
Copy link

codspeed-hq bot commented Sep 18, 2024

CodSpeed Performance Report

Merging #6563 will not alter performance

Comparing alfie/minimal-cargo-workspace-changes (3913b8f) with master (a0f5cf0)

Summary

✅ 22 untouched benchmarks

@alfiedotwtf alfiedotwtf marked this pull request as draft September 18, 2024 12:12
@alfiedotwtf alfiedotwtf marked this pull request as ready for review September 18, 2024 13:17
@alfiedotwtf alfiedotwtf force-pushed the alfie/minimal-cargo-workspace-changes branch 5 times, most recently from 757580c to 1b96c15 Compare September 19, 2024 21:15
Cargo.lock Outdated Show resolved Hide resolved
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@JoshuaBatty JoshuaBatty requested a review from a team September 20, 2024 04:14
@JoshuaBatty JoshuaBatty merged commit ab1e030 into master Sep 20, 2024
41 checks passed
@JoshuaBatty JoshuaBatty deleted the alfie/minimal-cargo-workspace-changes branch September 20, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci code quality dependencies dev-experience Anything to do with the developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants