Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix typo in forc-unit tests #6566

Merged
merged 4 commits into from
Sep 18, 2024
Merged

ci: Fix typo in forc-unit tests #6566

merged 4 commits into from
Sep 18, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Sep 18, 2024

Description

This typo was introduced here: 5e24673#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR465

& should be &&

It caused the exit code to be 0 even though some of the tests fails to compile. Example: https://github.com/FuelLabs/sway/actions/runs/10865968373/job/30152989834#step:6:86

image

Thanks @alfiedotwtf for noticing these failing tests!

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review September 18, 2024 17:56
@sdankel sdankel requested review from a team as code owners September 18, 2024 17:56
@sdankel sdankel requested review from IGI-111, bitzoic and a team September 18, 2024 17:57
@sdankel sdankel enabled auto-merge (squash) September 18, 2024 17:57
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 , nice catch!

@sdankel sdankel merged commit 15c8298 into master Sep 18, 2024
39 checks passed
@sdankel sdankel deleted the sophie/forc-unit-tests branch September 18, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants