Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forc-deploy block url #6570

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: forc-deploy block url #6570

merged 1 commit into from
Sep 19, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Sep 19, 2024

Description

It looks like there was a change in how fuel core client returns the block height. It used to be a hex number and we had to convert it to decimal, but now it’s returning the number as a decimal so we don't need to convert it.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review September 19, 2024 18:34
@sdankel sdankel requested a review from a team as a code owner September 19, 2024 18:34
@sdankel sdankel enabled auto-merge (squash) September 19, 2024 18:39
@kayagokalp kayagokalp requested a review from a team September 19, 2024 19:53
@kayagokalp kayagokalp added forc-client Everything related to the `forc-client` crate. forc-deploy Everything to do with forc-deploy labels Sep 19, 2024
Copy link
Contributor

@alfiedotwtf alfiedotwtf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code didn't prepend block_url if it was already decimal? That looks like a bug that's now been fixed in your PR. Two birds :)

@sdankel sdankel merged commit a0f5cf0 into master Sep 19, 2024
39 checks passed
@sdankel sdankel deleted the sophie/block_url branch September 19, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forc-client Everything related to the `forc-client` crate. forc-deploy Everything to do with forc-deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants