Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof that #6324 is not a bug. #6573

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Proof that #6324 is not a bug. #6573

merged 3 commits into from
Nov 19, 2024

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Sep 20, 2024

Description

The reproduction presented in #6324 was missing loading the storage configuration properly.

To do that we have to use the following in test/src/sdk-harness/test_projects/run_external_proxy_with_storage/mod.rs:

StorageConfiguration::default().add_slot_overrides_from_file("test_projects/run_external_target_with_storage/out/release/run_external_target_with_storage-storage_slots.json").unwrap();

This commit changes the presented reproduction to load the storage slots and the test runs without reverting.

Closes #6324

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal esdrubal added the audit-report Related to the audit report label Sep 20, 2024
@esdrubal esdrubal self-assigned this Sep 20, 2024
The reproduction presented in #6324 was missing loading the storage
configuration properly.

To do that we have to use the following in test/src/sdk-harness/test_projects/run_external_proxy_with_storage/mod.rs:
    StorageConfiguration::default().add_slot_overrides_from_file("test_projects/run_external_target_with_storage/out/release/run_external_target_with_storage-storage_slots.json").unwrap();

This commit changes the presented reproduction to load the storage slots
and the test runs without reverting.

Closes #6324
@esdrubal esdrubal marked this pull request as ready for review November 18, 2024 09:21
@esdrubal esdrubal requested a review from a team as a code owner November 18, 2024 09:21
@IGI-111 IGI-111 requested a review from a team November 19, 2024 02:53
@tritao tritao merged commit 0969ff2 into master Nov 19, 2024
39 checks passed
@tritao tritao deleted the esdrubal/run_external_proxy branch November 19, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit-report Related to the audit report
Projects
None yet
3 participants