Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proxy deployments for contracts with storage #6591

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Sep 26, 2024

Description

Fixes an issue where storage access wasn't working for proxied contracts. The fix is passing the combined storage slots to the proxy contract.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review September 26, 2024 20:24
@sdankel sdankel requested a review from a team as a code owner September 26, 2024 20:24
@sdankel sdankel requested a review from hal3e September 26, 2024 20:26
kayagokalp
kayagokalp previously approved these changes Sep 26, 2024
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an interesting one! I wasn't aware we need to add storage slots of the target contract to the proxy deployment as well. Thanks a lot for catching this 🙌

Edit: looks like contract ids needs update

@kayagokalp kayagokalp requested a review from a team September 26, 2024 20:57
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdankel sdankel merged commit 344f1c5 into master Sep 26, 2024
39 checks passed
@sdankel sdankel deleted the sophie/proxy-storage-slots-fix branch September 26, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants