Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return type checked trait constraints #6604

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Oct 3, 2024

Description

This PR fixes #6382.

The issue was that TypeParameter::type_check_trait_constraints(...) mutates the type inside the TypeEngine, but it was not returning the new type-checked trait constraints.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Copy link

codspeed-hq bot commented Oct 3, 2024

CodSpeed Performance Report

Merging #6604 will not alter performance

Comparing xunilrj/fix-trait-constraint-type-check (0011fcf) with master (759bb9e)

Summary

✅ 22 untouched benchmarks

Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this?

@xunilrj xunilrj force-pushed the xunilrj/fix-trait-constraint-type-check branch from 5af5b52 to 0407765 Compare October 24, 2024 06:51
@xunilrj xunilrj requested a review from a team as a code owner October 24, 2024 06:51
@xunilrj
Copy link
Contributor Author

xunilrj commented Oct 24, 2024

Can we add a test for this?

Done.

@IGI-111 IGI-111 requested a review from a team October 29, 2024 10:27
@tritao tritao merged commit 5ff7c39 into master Oct 29, 2024
40 checks passed
@tritao tritao deleted the xunilrj/fix-trait-constraint-type-check branch October 29, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot Use Generic Trait in Trait Constraints
3 participants