feat: generate a loader abi of loaders generated for predicates and scripts #6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
force-pushed
the
kayagokalp/loader-abi
branch
from
1f2bb18 to
19c5f70
Compare
kayagokalp
commented
Oct 6, 2024
kayagokalp
added
enhancement
kayagokalp
requested review from
Voxelot,
mchristopher and
luizstacio
as code owners
hal3e
approved these changes
Oct 6, 2024
Merged
alfiedotwtf
reviewed
Oct 6, 2024
alfiedotwtf
reviewed
Oct 6, 2024
alfiedotwtf
approved these changes
Oct 6, 2024
Voxelot
approved these changes
Oct 6, 2024
JoshuaBatty
added a commit
that referenced
this pull request
Oct 6, 2024
## Description waiting on #6611 Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks a lot to @hal3e for helping debug this.
With this PR, there will be an additional abi in the
outfolder for predicates and scripts that are deployed as loaders following the{package_name}-loader-abi.jsonnaming convention.This PR adds
loader-abi.jsonfile generation capability to forc. To do so forc needs to have the old (original) and new (loader) data offsets of the script/predicate. After getting it the difference should be applied to all configurable slots to find out the new locations of the configurable slots inside the loader binary.Basically enables backwards compatibility with the older sdk releases. Since forc can now generate a loader abi with correct configurable offsets, it can be used to load the script as it is, (without the newer loader stuff) and everything will be still working.