Refactor monomorphization/type resolving code out of TypeCheckContext.
#6615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
added
compiler
tritao
force-pushed
the
type-resolve-refactor
branch
from
5df3f24 to
58c83da
Compare
CodSpeed Performance ReportMerging #6615 will not alter performanceComparing Summary
|
tritao
force-pushed
the
type-resolve-refactor
branch
from
5856586 to
b6dd0a3
Compare
tritao
requested review from
Voxelot,
mchristopher and
luizstacio
as code owners
…h` to type resolver.
tritao
force-pushed
the
type-resolve-refactor
branch
from
b6dd0a3 to
1cf0528
Compare
tritao
requested review from
jjcnn
and removed request for
mchristopher,
Voxelot and
luizstacio
jjcnn
reviewed
Oct 11, 2024
IGI-111
approved these changes
Oct 17, 2024
jjcnn
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mainly refactors some common monomorphization/type resolving code out of
TypeCheckContext, to be able to re-use this code for the symbol resolving pass as well, along with some other minor cleanups.It also helps with code quality in that this file is a big beast and so this makes it a bit more manageable to understand.
Main changes:
Refactor symbol resolve from root into lexical scope.
Refactor monomorphization/type resolving code out of TypeCheckContext.
Extract resolve_qualified_call_path_with_visibility_check_and_modpath to type resolver.
Extract resolve_call_path_with_visibility_check_and_modpath to type resolver.
Refactor type resolver trait into functions.