Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function dedup conf decode #6623

Merged
merged 11 commits into from
Oct 22, 2024
Merged

Function dedup conf decode #6623

merged 11 commits into from
Oct 22, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Oct 8, 2024

Description

This PR improves fn_dedup to also deduplicate config decode functions.

Given how early this optimization was running, some optimizations were being lost, because some functions only get identical at the final IR. I believe we chose to run this early to decrease the pressure in other passes, but to allow this pass to really coalesce decodes I think makes sense to run it again at the end.

I am also deleting from the IR functions that were being replaced. This allowed the new test to decrease around 100 bytes. Our old configurable test went from 7600 to 7250 bytes.

image

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #6623 will degrade performances by 16.23%

Comparing xunilrj/fn-dedup-conf-decode (0324443) with master (79170db)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master xunilrj/fn-dedup-conf-decode Change
document_symbol 4.4 ms 5.2 ms -16.23%

@xunilrj xunilrj marked this pull request as ready for review October 8, 2024 16:45
@xunilrj xunilrj requested a review from a team October 8, 2024 16:45
@JoshuaBatty JoshuaBatty requested review from a team as code owners October 8, 2024 22:18
@IGI-111 IGI-111 requested a review from a team October 17, 2024 23:51
@xunilrj xunilrj merged commit 492db76 into master Oct 22, 2024
40 checks passed
@xunilrj xunilrj deleted the xunilrj/fn-dedup-conf-decode branch October 22, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants