Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeInfo::UntypedEnum and TypeInfo::UntypedStruct. #6633

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Oct 14, 2024

Description

Adds TypeInfo::UntypedEnum and TypeInfo::UntypedStruct, which are used to represent untyped enums/structs pointing to a ParsedDeclId. These will be used for an upcoming PR that does name resolution as a standalone step before type checking.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao self-assigned this Oct 14, 2024
@tritao tritao added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Oct 14, 2024
Copy link

codspeed-hq bot commented Oct 14, 2024

CodSpeed Performance Report

Merging #6633 will improve performances by 21.54%

Comparing tritao:typeinfo-untyped (fa8154d) with master (c374a11)

Summary

⚡ 1 improvements
✅ 21 untouched benchmarks

Benchmarks breakdown

Benchmark master tritao:typeinfo-untyped Change
document_symbol 5.2 ms 4.3 ms +21.54%

@tritao tritao force-pushed the typeinfo-untyped branch 2 times, most recently from 4965bb3 to 1c3d9e1 Compare October 20, 2024 15:18
@tritao tritao marked this pull request as ready for review October 20, 2024 15:54
@tritao tritao requested a review from a team as a code owner October 20, 2024 15:54
@tritao tritao requested a review from a team October 24, 2024 14:31
@JoshuaBatty JoshuaBatty merged commit 31974b4 into FuelLabs:master Oct 24, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants