Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal changes to remove miden deps #6638

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Oct 15, 2024

Description

"miden" crate was yanked, so this is the minimal changeset to remove it as a dependency.
We may still keep some miden stuff around.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj requested review from a team as code owners October 15, 2024 10:43
vaivaswatha
vaivaswatha previously approved these changes Oct 15, 2024
kayagokalp
kayagokalp previously approved these changes Oct 15, 2024
JoshuaBatty
JoshuaBatty previously approved these changes Oct 15, 2024
Copy link

codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #6638 will improve performances by 20.91%

Comparing xunilrj/removing-miden-dep (3805b71) with master (b7e59f4)

Summary

⚡ 1 improvements
✅ 21 untouched benchmarks

Benchmarks breakdown

Benchmark master xunilrj/removing-miden-dep Change
document_symbol 5.3 ms 4.4 ms +20.91%

kayagokalp
kayagokalp previously approved these changes Oct 15, 2024
Cargo.toml Outdated Show resolved Hide resolved
@JoshuaBatty JoshuaBatty merged commit 9ecfb69 into master Oct 15, 2024
40 checks passed
@JoshuaBatty JoshuaBatty deleted the xunilrj/removing-miden-dep branch October 15, 2024 11:26
JoshuaBatty added a commit that referenced this pull request Oct 15, 2024
## Description
removes miden 

~~waiting on #6638~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants