-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal changes to remove miden deps #6638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaivaswatha
previously approved these changes
Oct 15, 2024
kayagokalp
previously approved these changes
Oct 15, 2024
JoshuaBatty
previously approved these changes
Oct 15, 2024
CodSpeed Performance ReportMerging #6638 will improve performances by 20.91%Comparing Summary
Benchmarks breakdown
|
Merged
xunilrj
dismissed stale reviews from JoshuaBatty, kayagokalp, and vaivaswatha
via
October 15, 2024 10:56
71ab956
kayagokalp
previously approved these changes
Oct 15, 2024
JoshuaBatty
reviewed
Oct 15, 2024
xunilrj
force-pushed
the
xunilrj/removing-miden-dep
branch
from
October 15, 2024 11:06
36501f0
to
3805b71
Compare
tritao
approved these changes
Oct 15, 2024
JoshuaBatty
approved these changes
Oct 15, 2024
IGI-111
approved these changes
Oct 15, 2024
JoshuaBatty
added a commit
that referenced
this pull request
Oct 15, 2024
## Description removes miden ~~waiting on #6638~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"miden" crate was yanked, so this is the minimal changeset to remove it as a dependency.
We may still keep some
miden
stuff around.Checklist
Breaking*
orNew Feature
labels where relevant.